-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable kubelet server to dynamically load tls certificate files #124574
Conversation
Welcome @zhangweikop! |
Hi @zhangweikop. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
I would suggest taking this feature to sig-auth. |
/remove-kind bug |
28de58a
to
da7c8e6
Compare
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
This LGTM from an auth perspective.
I will defer to SIG node to determine if they are happy with the code, and if this change requires a feature gate / if that gate should be enabled or disabled by default.
I confirmed SIG Auth's stance on this during the meeting today. There is a slight preference to have the feature gate since the wiring of this code is new, and it would be nice to provide an opt-out mechanism should something go wrong. |
The current feature gate in pr |
I am fine either way, so I will defer the default to SIG node. |
@mrunalp do you have any preference? |
} | ||
|
||
} else if kubeDeps.TLSOptions.CertFile != "" && kubeDeps.TLSOptions.KeyFile != "" && utilfeature.DefaultFeatureGate.Enabled(features.ReloadKubeletServerCertificateFile) { | ||
klet.serverCertificateManager, err = kubeletcertificate.NewKubeletServerCertificateDynamicFileManager(kubeDeps.TLSOptions.CertFile, kubeDeps.TLSOptions.KeyFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the changes in this commit to the next commit as the function isn't introduced yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could always just squash into one commit :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated commits history a bit
@@ -1159,6 +1167,8 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS | |||
|
|||
RelaxedEnvironmentVariableValidation: {Default: false, PreRelease: featuregate.Alpha}, | |||
|
|||
ReloadKubeletServerCertificateFile: {Default: true, PreRelease: featuregate.Beta}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this true sounds by default sounds fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c9538ea45eb9e7b8fd9480a486aaed4099489b2c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, zhangweikop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
It enable kubelet tls server to watch and reload certificate files.
In our kubelet deployment, we don't use
ServerTLSBootstrap
or let kubelet to create a self-signed cert.We have other mechanism (based on internal PKI & CA) to generate and rotate the certificate files for kubelet on each host.
Therefore, we want that kubelet TLS (both client and server side) can handle the certificate update. This feature is important for us when we start generating short shorter-lived certificates for kubelet
Currently in Kubelet:
In our testing, the kubelet -> API server requests never encountered issues. The pod can be deployed and started correctly on the host after the kubelet certificate file expired and then regenerated.
Special notes for your reviewer:
certificate.Manager
so that it could be used similarly to other struct in pkg/kubelet/certificate/kubelet.go.DynamicCertKeyPairContent
struct in k8s.io/apiserver/pkg/server/dynamiccertificates.Does this PR introduce a user-facing change?